ble

CommInterface.cpp

@@ -4,6 +4,8 @@
 #include "LiveData.h"
 
 void CommInterface::initComm(LiveData* pLiveData, BoardInterface* pBoard) {
+    
     liveData = pLiveData;   
     board = pBoard; 
+    response = "";  
 }

CommInterface.h

@@ -11,7 +11,7 @@ class CommInterface {
     LiveData* liveData;   
     BoardInterface* board;   
     char ch;
-    String line;
+    String response;
   public:
     void initComm(LiveData* pLiveData, BoardInterface* pBoard);
     virtual void connectDevice() = 0;

CommObd2Ble4.cpp

@@ -117,7 +117,7 @@ static void notifyCallback (BLERemoteCharacteristic * pBLERemoteCharacteristic,
 
   char ch;
 
-  // Parse multi line response to single lines
+  // Parse multiframes to single response
   liveDataObj->responseRow = "";
   for (int i = 0; i <= length; i++) {
     ch = pData[i];
@@ -129,7 +129,9 @@ static void notifyCallback (BLERemoteCharacteristic * pBLERemoteCharacteristic,
       liveDataObj->responseRow += ch;
       if (liveDataObj->responseRow == ">") {
         if (liveDataObj->responseRowMerged != "") {
-          commObj->parseRowMerged();
+          Serial.print("merged:");
+          Serial.println(liveDataObj->responseRowMerged);
+          boardObj->parseRowMerged();
         }
         liveDataObj->responseRowMerged = "";
         liveDataObj->canSendNextAtCommand = true;
@@ -146,7 +148,6 @@ void CommObd2Ble4::connectDevice() {
   commObj = this;
   liveDataObj = liveData;
   boardObj = board;
-  line = "";
 
   Serial.println("BLE4 connectDevice");
 
@@ -313,7 +314,7 @@ bool CommObd2Ble4::connectToServer(BLEAddress pAddress) {
 }
 
 /**
- * Main loop
+   Main loop
 */
 void CommObd2Ble4::mainLoop() {
 
@@ -341,15 +342,15 @@ void CommObd2Ble4::mainLoop() {
   if (Serial.available()) {
     ch = Serial.read();
     if (ch == '\r' || ch == '\n') {
-      board->customConsoleCommand(line);
-      line = line + ch;
-      Serial.println(line);
+      board->customConsoleCommand(response);
+      response = response + ch;
+      Serial.println(response);
       if (liveData->bleConnected) {
-        liveData->pRemoteCharacteristicWrite->writeValue(line.c_str(), line.length());
+        liveData->pRemoteCharacteristicWrite->writeValue(response.c_str(), response.length());
       }
-      line = "";
+      response = "";
     } else {
-      line = line + ch;
+      response = response + ch;
     }
   }
 
@@ -396,12 +397,11 @@ bool CommObd2Ble4::doNextAtCommand() {
 }
 
 /**
-  Parse result from OBD, create single line liveData->responseRowMerged
+  Parse result from OBD, merge frames to sigle response
 */
 bool CommObd2Ble4::parseRow() {
 
-  // Simple 1 line responses
-  Serial.print("");
+  // 1 frame data
   Serial.println(liveData->responseRow);
 
   // Merge 0:xxxx 1:yyyy 2:zzzz to single xxxxyyyyzzzz string
@@ -411,17 +411,3 @@ bool CommObd2Ble4::parseRow() {
 
   return true;
 }
-
-/**
-  Parse merged row (after merge completed)
-*/
-bool CommObd2Ble4::parseRowMerged() {
-
-  Serial.print("merged:");
-  Serial.println(liveData->responseRowMerged);
-
-  // Parse by selected car interface
-  board->parseRowMerged();
-
-  return true;
-}

CommObd2Ble4.h

@@ -18,5 +18,5 @@ class CommObd2Ble4 : public CommInterface {
     bool connectToServer(BLEAddress pAddress);
     bool doNextAtCommand();
     bool parseRow();
-    bool parseRowMerged();
+    //
 };

CommObd2Can.cpp

@@ -7,8 +7,6 @@
 */
 void CommObd2Can::connectDevice() {
 
-  line = "";
- 
   Serial.println("CAN connectDevice");
 }