From 2987803042f82eb330299e4cab70197730f87cf2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcel=20St=C3=B6r?= Date: Sun, 5 Aug 2018 20:35:23 +0200 Subject: [PATCH] Switch to OWM xxxById functions Requires weather station library 1.6.1+. Fixes #81 --- esp8266-weather-station-color.ino | 4 ++-- settings.h | 8 +++++++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/esp8266-weather-station-color.ino b/esp8266-weather-station-color.ino index 425d051..44af891 100644 --- a/esp8266-weather-station-color.ino +++ b/esp8266-weather-station-color.ino @@ -286,7 +286,7 @@ void updateData() { OpenWeatherMapCurrent *currentWeatherClient = new OpenWeatherMapCurrent(); currentWeatherClient->setMetric(IS_METRIC); currentWeatherClient->setLanguage(OPEN_WEATHER_MAP_LANGUAGE); - currentWeatherClient->updateCurrent(¤tWeather, OPEN_WEATHER_MAP_APP_ID, OPEN_WEATHER_MAP_LOCATION); + currentWeatherClient->updateCurrentById(¤tWeather, OPEN_WEATHER_MAP_APP_ID, OPEN_WEATHER_MAP_LOCATION_ID); delete currentWeatherClient; currentWeatherClient = nullptr; @@ -296,7 +296,7 @@ void updateData() { forecastClient->setLanguage(OPEN_WEATHER_MAP_LANGUAGE); uint8_t allowedHours[] = {12, 0}; forecastClient->setAllowedHours(allowedHours, sizeof(allowedHours)); - forecastClient->updateForecasts(forecasts, OPEN_WEATHER_MAP_APP_ID, OPEN_WEATHER_MAP_LOCATION, MAX_FORECASTS); + forecastClient->updateForecastsById(forecasts, OPEN_WEATHER_MAP_APP_ID, OPEN_WEATHER_MAP_LOCATION_ID, MAX_FORECASTS); delete forecastClient; forecastClient = nullptr; diff --git a/settings.h b/settings.h index 0f173ca..c47c943 100644 --- a/settings.h +++ b/settings.h @@ -32,7 +32,13 @@ const int SLEEP_INTERVAL_SECS = 0; // Going to Sleep after idle times, set 0 f // OpenWeatherMap Settings // Sign up here to get an API key: https://docs.thingpulse.com/how-tos/openweathermap-key/ String OPEN_WEATHER_MAP_APP_ID = ""; -String OPEN_WEATHER_MAP_LOCATION = "Zurich,CH"; +/* +Go to https://openweathermap.org/find?q= and search for a location. Go through the +result set and select the entry closest to the actual location you want to display +data for. It'll be a URL like https://openweathermap.org/city/2657896. The number +at the end is what you assign to the constant below. + */ +String OPEN_WEATHER_MAP_LOCATION_ID = "2657896"; /* Arabic -> ar, Bulgarian -> bg, Catalan -> ca, Czech -> cz, German -> de, Greek -> el, English -> en, Persian (Farsi) -> fa, Finnish -> fi, French -> fr, Galician -> gl,